-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add tag entries page #2527
ui: add tag entries page #2527
Conversation
975b33c
to
de6e842
Compare
e88282a
to
51ee18d
Compare
Performance seems to be ok with the |
01fe46e
to
b92f5c1
Compare
@fguillot Can I have a feedback on this feature and a review of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if separating the unread and all article views on the tags page makes sense in this context.
Below is an example in a screen recording where I open a read entry and click on a tag. The fact that the page doesn't display any entries might confuse people.
Recording.2024-04-03.203743.mp4
Not sure about what to do. Both unread and all entries pages are interesting in my use case. Maybe I can order entries to show unread entries first (order by status and date instead of only date) |
de7bfae
to
1f26aba
Compare
6104ce9
to
5067cd1
Compare
@fguillot Sorry to ping you again but can you review my PR again please?
I implemented this instead of having both unread and all pages and I would like to know your opinion on this :) |
Sounds good. |
fix #2522
This PR bring a page to show entries related to a same tag
I open this draft PR to get some suggestions on that feature
text[]
). This is not the more optimal, a dedicated table would be better I thinkDo you follow the guidelines?