Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bootstrap.js #2476

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Simplify bootstrap.js #2476

merged 1 commit into from
Mar 14, 2024

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Mar 11, 2024

  • Don't use lambdas to return a function, use directly the function instead.

  • Use the ?. operator instead of an if

  • Remove a hack for "Chrome 67 and earlier" since it was released in 2018.

  • I have tested my changes

  • I read this document: https://miniflux.app/faq.html#pull-request

@fguillot
Copy link
Member

This PR has some conflicts detected

- Don't use lambdas to return a function, use directly the function instead.
- Remove a hack for "Chrome 67 and earlier" since it was released in 2018.
@fguillot fguillot merged commit d25c032 into miniflux:main Mar 14, 2024
17 checks passed
@jvoisin jvoisin deleted the bootstrap branch March 14, 2024 08:59
fguillot added a commit that referenced this pull request Mar 16, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
fguillot added a commit that referenced this pull request Mar 16, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
jeankhawand pushed a commit to jeankhawand/v2 that referenced this pull request Mar 19, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
jeankhawand pushed a commit to jeankhawand/v2 that referenced this pull request Mar 19, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
jeankhawand pushed a commit to jeankhawand/v2 that referenced this pull request Mar 20, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
tfaughnan pushed a commit to tfaughnan/miniflux that referenced this pull request Mar 31, 2024
'Toast' messages are broken and v hotkey opens in the same tab

Commit d25c032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants