Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark above entries as read #2328

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Jayphen
Copy link

@Jayphen Jayphen commented Feb 3, 2024

Hello!

Often when scrolling a long list of entries, I want to "mark my progress".

This PR introduces a "mark above as read" button to a feed item, which will mark all entries above (not including) the current one as read.

This is not immediately ready to merge as the title requires a translation, and perhaps a different icon should be used (I used the same as mark all as read). I was not sure what icon to select.

image

Do you follow the guidelines?

@Jayphen Jayphen changed the title Mark above entries as read feat: Mark above entries as read Feb 4, 2024
@krvpb024 krvpb024 mentioned this pull request Feb 5, 2024
2 tasks
@Jayphen Jayphen marked this pull request as draft February 9, 2024 13:39
@Jayphen
Copy link
Author

Jayphen commented Feb 9, 2024

I have moved this to draft in light of the changes made by @krvpb024 — I will review the accessibility of the approach taken here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant