-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show author of a post in the feed list #1424
Conversation
IMHO it is interesting to see the author of an entry right in the list. Truncated to 35 characters as the feed title is.
I do understand that. Though, on small devices the line breaks anyway with longer feed titles. What about a checkbox in the settings for this? I am not sure whether I will soon find the time to figure out how to implement that, though. |
@@ -4,6 +4,11 @@ | |||
<li class="item-meta-info-title"> | |||
<a href="{{ route "feedEntries" "feedID" .entry.Feed.ID }}" title="{{ .entry.Feed.SiteURL }}" data-feed-link="true">{{ truncate .entry.Feed.Title 35 }}</a> | |||
</li> | |||
{{ if .entry.Author }} | |||
<li class="item-meta-info-author"> | |||
<em title="{{ .entry.Author }}">{{ truncate .entry.Author 35 }}</em> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the semantic meaning for using <em>
? If the answer is: to visually style the element in italics, then this should prefer CSS over using the <em>
element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I had no specific reason to choose <em>
over something less semantic 😬
If you think it is inappropriate I am happy to (have you) change it to e.g. <span>
or remove the extra inline element completely, if that would not break stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.item-meta-info-author {
font-style: italic;
}
is all that would be needed.
Should truncation happen with CSS instead of actually chopping the markup? |
Are you asking me? I don't know. This PR is just about showing the author of a post at all. I tried to keep the code base as similar as possible to the rest of the code and do not intend to alter/replace/improve code design in general. |
Yes, it would even make sense to have this option per feed. |
It being an option per feed would be nice. Most blogs have the author's name as the feed title anyway. |
IMHO it is interesting to see the author of an entry right in the list.
Truncated to 35 characters as the feed title is.
Do you follow the guidelines?