fix: do not store empty tags

miniflux · Mar 23, 2024 · 7184662 · 7184662
1 parent 7ee4a73
commit 7184662
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/internal/database/migrations.go b/internal/database/migrations.go
@@ -876,4 +876,9 @@ var migrations = []func(tx *sql.Tx) error{
 		_, err = tx.Exec(sql)
 		return err
 	},
+	func(tx *sql.Tx) (err error) {
+		sql := `UPDATE entries SET tags = array_remove(tags, '') WHERE '' = ANY(tags);`
+		_, err = tx.Exec(sql)
+		return err
+	},
 }
diff --git a/internal/storage/entry.go b/internal/storage/entry.go
@@ -139,7 +139,7 @@ func (s *Storage) createEntry(tx *sql.Tx, entry *model.Entry) error {
 		entry.UserID,
 		entry.FeedID,
 		entry.ReadingTime,
-		pq.Array(removeDuplicates(entry.Tags)),
+		pq.Array(removeEmpty(removeDuplicates(entry.Tags))),
 	).Scan(
 		&entry.ID,
 		&entry.Status,
@@ -195,7 +195,7 @@ func (s *Storage) updateEntry(tx *sql.Tx, entry *model.Entry) error {
 		entry.UserID,
 		entry.FeedID,
 		entry.Hash,
-		pq.Array(removeDuplicates(entry.Tags)),
+		pq.Array(removeEmpty(removeDuplicates(entry.Tags))),
 	).Scan(&entry.ID)
 
 	if err != nil {
@@ -620,3 +620,13 @@ func removeDuplicates(l []string) []string {
 	slices.Sort(l)
 	return slices.Compact(l)
 }
+
+func removeEmpty(l []string) []string {
+	finalSlice := []string{}
+	for _, item := range l {
+		if item != "" {
+			finalSlice = append(finalSlice, item)
+		}
+	}
+	return finalSlice
+}