-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter_boxes method #332
Conversation
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 94.69% 94.72% +0.03%
==========================================
Files 83 83
Lines 3296 3335 +39
==========================================
+ Hits 3121 3159 +38
- Misses 175 176 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I added a few improvement suggestions
Also, this PR modifies the default output behaviour (cf the failed unittest in the API) |
Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
For further reference, since this changes the default behaviour of the detection part, should we update the benchmark tables as well? (to ensure it's a positive change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had another thought of merging both bbox resolution function since they indeed have the same purpose. The rest looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This PR adds a filter_boxes method in the core DetectionPostProcessor which performs the following:
For now, only straight bounding boxes are supported, as the computation of NMS/boxes to merge is slightly harder when dealing with rotated boxes. In case of rotated boxes, it will simply return the array of boxes without filtering.
Any feeback is welcome!