Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] update api for multi file and pdf support #1522

Merged
merged 11 commits into from
Apr 11, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Mar 25, 2024

This PR:

  • update API template to support multiple images and/or pdfs
  • add config options
  • extend tests

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Mar 25, 2024
@felixdittrich92 felixdittrich92 self-assigned this Mar 25, 2024
@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: api Related to api folder labels Mar 25, 2024
@felixdittrich92 felixdittrich92 marked this pull request as ready for review March 25, 2024 15:31
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (8c85c36) to head (73e3faa).
Report is 1 commits behind head on main.

❗ Current head 73e3faa differs from pull request most recent head 9137f09. Consider uploading reports for the commit 9137f09 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         166      166           
  Lines        7648     7648           
=======================================
  Hits         7328     7328           
  Misses        320      320           
Flag Coverage Δ
unittests 95.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/README.md Outdated Show resolved Hide resolved
api/app/routes/kie.py Outdated Show resolved Hide resolved
api/tests/routes/test_detection.py Outdated Show resolved Hide resolved
api/tests/routes/test_kie.py Outdated Show resolved Hide resolved
@felixdittrich92
Copy link
Contributor Author

felixdittrich92 commented Apr 10, 2024

Extended with more configuration options: (which was planned for a follow up PR 😅)

Also improved tests with a small tolerance for model updates (should not change much in the future so response mocks are fine)
Closses: #1537 also

@felixdittrich92
Copy link
Contributor Author

Fixed CI (which was green before but hasn't run any test 😅)

@felixdittrich92
Copy link
Contributor Author

felixdittrich92 commented Apr 11, 2024

CC @eudoxos

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome works here, thank you Felix !

api/Makefile Show resolved Hide resolved
@felixdittrich92 felixdittrich92 merged commit d932175 into mindee:main Apr 11, 2024
66 of 68 checks passed
@felixdittrich92 felixdittrich92 deleted the api-multi branch April 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api] Add support of PDF / multi-image inputs in the API template
2 participants