Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
NOTE:
I double used the lstmcell on decoder side in pytorch, this explains the small difference in model parameters: TF: 57.2 M --> PT: 55.4 M -> but it does not impact the result quality (as you can see in the benchmarks there is no drop) so i don't see any need to fix and retrain the pt model
Any feedback is welcome 🤗
Closes: #1411 #1441