Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] drop py 3.8 support #1457

Merged
merged 13 commits into from
Mar 29, 2024
Merged

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Feb 8, 2024

On hold - after release 0.8.0

This PR:

  • drop py3.8 support (with the next release this should be fine -> https://devguide.python.org/versions/)
  • tf still keeped with lower boundary at >=2.11
  • fixed to <2.16.0 because keras-core (keras3) would destroy the whole TF part - needs to be updated in another PR - breaking change
  • modified the references jobs a bit for speed up

TF:

Support for Python 3.8 has been removed starting with TF 2.14. The TensorFlow 2.13.1 patch release will still have Python 3.8 support.

https://github.com/tensorflow/tensorflow/releases/tag/v2.14.0

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (8c85c36) to head (c7c1f3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   95.81%   95.80%   -0.02%     
==========================================
  Files         166      166              
  Lines        7648     7648              
==========================================
- Hits         7328     7327       -1     
- Misses        320      321       +1     
Flag Coverage Δ
unittests 95.80% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 changed the title [Misc] drop py 3.8 support [DRAFT] [Misc] drop py 3.8 support Feb 8, 2024
@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee Let's talk about this next week again i don't think that it raises any impact on your side if you use a pinned doctr version.
For development it's crucical because in our CI with py3.8 we are bound to TF <= 2.13 / which makes it also not possible to work on the breaking keras changes in >= TF 2.16 :)

@felixdittrich92
Copy link
Contributor Author

@odulcy-mindee
If your internal usage of doctr is pinned (what i thing) we could merge this also and update the github ci jobs :)
Before this isn't merged it makes less sense to work on support for TF >2.14 (>=2.16 with keras-v3) ^^

@felixdittrich92 felixdittrich92 marked this pull request as ready for review March 15, 2024 14:44
pyproject.toml Outdated Show resolved Hide resolved
@felixdittrich92 felixdittrich92 changed the title [DRAFT] [Misc] drop py 3.8 support [Misc] drop py 3.8 support Mar 15, 2024
@felixdittrich92 felixdittrich92 self-assigned this Mar 15, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Mar 15, 2024
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build topic: ci Related to CI topic: docker Docker-related type: misc Miscellaneous labels Mar 15, 2024
api/pyproject.toml Outdated Show resolved Hide resolved
@odulcy-mindee odulcy-mindee merged commit 0d84915 into mindee:main Mar 29, 2024
70 checks passed
@felixdittrich92 felixdittrich92 deleted the drop-py38 branch March 29, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build topic: ci Related to CI topic: docker Docker-related type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants