Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc & build] replace isort pydocstyle and black with ruff #1379

Merged
merged 16 commits into from
Nov 15, 2023

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Nov 10, 2023

This PR:

  • remove isort black and pydocstyle it's handled with ruff now
  • improve and fix some docstrings
  • fix for newest mypy Version
  • fix docs: JSON export -> export

Any feedback is welcome 🤗
@odulcy-mindee this would require again to update the required ci job settings :)

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e00cc79) 95.78% compared to head (1339101) 95.78%.

Files Patch % Lines
doctr/datasets/detection.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         155      155              
  Lines        6952     6948       -4     
==========================================
- Hits         6659     6655       -4     
  Misses        293      293              
Flag Coverage Δ
unittests 95.78% <97.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 modified the milestones: Uhu, 0.8.0 Nov 10, 2023
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build topic: ci Related to CI type: misc Miscellaneous type: code quality Related to code quality ext: docs Related to docs folder labels Nov 10, 2023
@felixdittrich92 felixdittrich92 marked this pull request as ready for review November 10, 2023 16:03
@felixdittrich92 felixdittrich92 changed the title [DRAFT] [misc & build] replace isort pydocstyle and black with ruff and update to py3.9 min [misc & build] replace isort pydocstyle and black with ruff and update to py3.9 min Nov 10, 2023
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to use ruff but I'm not comfortable about dropping Python 3.8 version as it may have a wider impact.

@felixdittrich92
Copy link
Contributor Author

I'm fine to use ruff but I'm not comfortable about dropping Python 3.8 version as it may have a wider impact.

I completely agree with you py3.8 end-of-life is in the fall of next year...however TF has already moved to >=py3.9 :/
ref: https://pypi.org/project/tensorflow/

@felixdittrich92 felixdittrich92 changed the title [misc & build] replace isort pydocstyle and black with ruff and update to py3.9 min [misc & build] replace isort pydocstyle and black with ruff Nov 13, 2023
@odulcy-mindee
Copy link
Collaborator

I completely agree with you py3.8 end-of-life is in the fall of next year...however TF has already moved to >=py3.9 :/

Yeah, I saw that after tf 2.14 :-/

api/tests/routes/test_detection.py Outdated Show resolved Hide resolved
doctr/datasets/svt.py Show resolved Hide resolved
doctr/transforms/modules/tensorflow.py Show resolved Hide resolved
@felixT2K
Copy link
Contributor

I completely agree with you py3.8 end-of-life is in the fall of next year...however TF has already moved to >=py3.9 :/

Yeah, I saw that after tf 2.14 :-/

And 2.16 will break everything because 2.15 will be the last release with keras v2 in 2.16 (hopefully 3.0) it will integrate keras v3 (keras-core) and break the whole save and load logic (the way how we save and load tf checkpoints in doctr will not be anymore supported with keras 😅 )

@felixdittrich92 felixdittrich92 merged commit 6d92df5 into mindee:main Nov 15, 2023
66 of 67 checks passed
@felixdittrich92 felixdittrich92 deleted the ruff-mod branch November 15, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder topic: build Related to dependencies and build topic: ci Related to CI type: code quality Related to code quality type: misc Miscellaneous
Projects
None yet
3 participants