-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc & build] replace isort pydocstyle and black with ruff #1379
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
- Coverage 95.78% 95.78% -0.01%
==========================================
Files 155 155
Lines 6952 6948 -4
==========================================
- Hits 6659 6655 -4
Misses 293 293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine to use ruff
but I'm not comfortable about dropping Python 3.8 version as it may have a wider impact.
I completely agree with you py3.8 end-of-life is in the fall of next year...however TF has already moved to >=py3.9 :/ |
Yeah, I saw that after tf 2.14 :-/ |
And 2.16 will break everything because 2.15 will be the last release with keras v2 in 2.16 (hopefully 3.0) it will integrate keras v3 (keras-core) and break the whole save and load logic (the way how we save and load tf checkpoints in doctr will not be anymore supported with keras 😅 ) |
This PR:
Any feedback is welcome 🤗
@odulcy-mindee this would require again to update the required ci job settings :)