Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix growing mem usage pytorch crnn #1357

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fix growing mem usage
  • training still works

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models framework: pytorch Related to PyTorch backend topic: text recognition Related to the task of text recognition labels Oct 19, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Oct 19, 2023
@felixdittrich92 felixdittrich92 self-assigned this Oct 19, 2023
@felixdittrich92 felixdittrich92 linked an issue Oct 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1357 (c9ae4a9) into main (e83c3ab) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
+ Coverage   95.78%   95.80%   +0.01%     
==========================================
  Files         154      154              
  Lines        6910     6909       -1     
==========================================
  Hits         6619     6619              
+ Misses        291      290       -1     
Flag Coverage Δ
unittests 95.80% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
doctr/datasets/vocabs.py 100.00% <100.00%> (ø)
doctr/models/recognition/crnn/pytorch.py 94.56% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, funny to see it fixed this issue. Thanks !

@felixdittrich92 felixdittrich92 merged commit bc2d3c5 into mindee:main Oct 20, 2023
70 checks passed
@felixdittrich92 felixdittrich92 deleted the crnn-mem-leak-fix branch October 20, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text recognition Related to the task of text recognition type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory issue crnn
2 participants