Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transforms] update random apply to work also with targets #1333

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Sep 27, 2023

This PR:

  • extends RandomApply to work also with transformations which takes targets

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: references Related to references folder module: transforms Related to doctr.transforms topic: text detection Related to the task of text detection labels Sep 27, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Sep 27, 2023
@felixdittrich92 felixdittrich92 self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1333 (5e9e428) into main (3271460) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         154      154           
  Lines        6902     6902           
=======================================
  Hits         6611     6611           
  Misses        291      291           
Flag Coverage Δ
unittests 95.78% <95.23%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
doctr/models/classification/predictor/pytorch.py 95.45% <100.00%> (ø)
doctr/models/detection/predictor/pytorch.py 95.23% <100.00%> (ø)
doctr/models/kie_predictor/pytorch.py 100.00% <100.00%> (ø)
doctr/models/predictor/pytorch.py 100.00% <100.00%> (ø)
doctr/models/recognition/parseq/pytorch.py 97.16% <100.00%> (ø)
doctr/models/recognition/parseq/tensorflow.py 97.33% <100.00%> (ø)
doctr/models/recognition/predictor/pytorch.py 91.66% <100.00%> (ø)
doctr/models/recognition/vitstr/pytorch.py 100.00% <100.00%> (ø)
doctr/models/recognition/vitstr/tensorflow.py 97.61% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <75.00%> (ø)

@felixdittrich92 felixdittrich92 merged commit 19f101c into mindee:main Sep 27, 2023
57 of 58 checks passed
@felixdittrich92 felixdittrich92 deleted the update-random-apply branch September 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder module: transforms Related to doctr.transforms topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants