Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Hide buggy search iterator interface #837

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

congqixia
Copy link
Contributor

Current implementation is buggy and not ready for prod. Hide it until fixed.

Current implementation is buggy and not ready for prod. Hide it until
fixed.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Oct 23, 2024
@congqixia congqixia changed the title enhance: Hide buggy search iterator interface enhance: [2.4] Hide buggy search iterator interface Oct 23, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 23, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Oct 23, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 23, 2024
@sre-ci-robot sre-ci-robot merged commit 9cc0d6c into milvus-io:v2.4.x Oct 23, 2024
7 checks passed
@congqixia congqixia deleted the fix24/hide_search_iterator branch October 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants