Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add resource group declarative api #733

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 22, 2024

issue: milvus-io/milvus#32282

  • Add UpdateResourceGroups and modify AddResourceGroup api.

  • Add example for add resource group declarative api.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 22, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Apr 22, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added lgtm look good to me and removed lgtm look good to me labels Apr 22, 2024
@mergify mergify bot removed the ci-passed auto merge needed label label Apr 23, 2024
@chyezh chyezh force-pushed the enhance_declarative_resource_group branch 2 times, most recently from 2b0d255 to 082526d Compare April 30, 2024 06:59
@chyezh chyezh force-pushed the enhance_declarative_resource_group branch 2 times, most recently from 85ad3db to 70e7308 Compare May 23, 2024 07:46
- Add UpdateResourceGroups and modify AddResourceGroup api.

- Add example for add resource group declarative api.

Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_declarative_resource_group branch from 70e7308 to 95af4cc Compare June 13, 2024 07:43
@mergify mergify bot added the ci-passed auto merge needed label label Jun 13, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 17, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jun 17, 2024
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Jun 17, 2024
@sre-ci-robot sre-ci-robot merged commit d346d3e into milvus-io:master Jun 17, 2024
7 checks passed
@chyezh chyezh deleted the enhance_declarative_resource_group branch June 17, 2024 05:44
siddarth99 pushed a commit to siddarth99/milvus-sdk-go that referenced this pull request Jun 17, 2024
issue: milvus-io/milvus#32282

- Add UpdateResourceGroups and modify AddResourceGroup api.

- Add example for add resource group declarative api.

---------

Signed-off-by: chyezh <[email protected]>
Signed-off-by: Sidharth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants