Skip to content

Commit

Permalink
test: verify bitmap cases (#796)
Browse files Browse the repository at this point in the history
Signed-off-by: wangting0128 <[email protected]>
  • Loading branch information
wangting0128 authored Aug 7, 2024
1 parent 9f31674 commit 93f6e5c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
12 changes: 7 additions & 5 deletions test/testcases/index_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ func TestCreateIndexDup(t *testing.T) {

// test create scalar index on all scalar field
func TestCreateScalarIndex(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34795")
ctx := createContext(t, time.Second*common.DefaultTimeout)
//connect
mc := createMilvusClient(ctx, t)
Expand Down Expand Up @@ -216,7 +215,6 @@ func TestCreateScalarIndex(t *testing.T) {

// test create scalar index on loaded collection
func TestCreateIndexOnLoadedCollection(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34404")
ctx := createContext(t, time.Second*common.DefaultTimeout)
//connect
mc := createMilvusClient(ctx, t)
Expand Down Expand Up @@ -265,6 +263,13 @@ func TestCreateIndexOnLoadedCollection(t *testing.T) {

err = mc.LoadCollection(ctx, collName, false)
common.CheckErr(t, err, true)

for _, field := range coll.Schema.Fields {
if supportScalarIndexFieldType(field.DataType) {
_, err := mc.DescribeIndex(ctx, collName, field.Name)
common.CheckErr(t, err, true, "")
}
}
}

// Trie scalar index only supported on varchar
Expand Down Expand Up @@ -396,7 +401,6 @@ func TestCreateInvertedScalarIndex(t *testing.T) {

// create Bitmap index for all scalar fields
func TestCreateBitmapScalarIndex(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34795")
ctx := createContext(t, time.Second*common.DefaultTimeout*2)
// connect
mc := createMilvusClient(ctx, t)
Expand Down Expand Up @@ -641,7 +645,6 @@ func TestCreateInvertedIndexArrayField(t *testing.T) {
}

func TestCreateBitmapIndexOnArrayField(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34797")
ctx := createContext(t, time.Second*common.DefaultTimeout)
// connect
mc := createMilvusClient(ctx, t)
Expand Down Expand Up @@ -857,7 +860,6 @@ func TestCreateIndexWithoutIndexTypeParams(t *testing.T) {

// test create default auto index on scalar fields, array and json -> error
func TestCreateAutoIndexScalarFields(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34795")
ctx := createContext(t, time.Second*common.DefaultTimeout)
//connect
mc := createMilvusClient(ctx, t)
Expand Down
1 change: 0 additions & 1 deletion test/testcases/query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,6 @@ func TestQueryCountJsonDynamicExpr(t *testing.T) {

// test query with all kinds of array expr
func TestQueryArrayFieldExpr(t *testing.T) {
t.Skip("https://github.com/milvus-io/milvus/issues/34797")
ctx := createContext(t, time.Second*common.DefaultTimeout)
// connect
mc := createMilvusClient(ctx, t)
Expand Down

0 comments on commit 93f6e5c

Please sign in to comment.