Skip to content

Commit

Permalink
enhance: Sync autoID insert/upsert test cases (#788)
Browse files Browse the repository at this point in the history
Insert/Upsert behavior changes for milvus master branch. This PR updates
some error message and error check for upsert with PKs when autoID=true.

Signed-off-by: Congqi Xia <[email protected]>
  • Loading branch information
congqixia authored Jul 16, 2024
1 parent a8b2932 commit 869db52
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/testcases/insert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestInsertAutoIdPkData(t *testing.T) {
// insert
pkColumn, floatColumn, vecColumn := common.GenDefaultColumnData(0, common.DefaultNb, common.DefaultDim)
_, errInsert := mc.Insert(ctx, collName, "", pkColumn, floatColumn, vecColumn)
common.CheckErr(t, errInsert, false, "can not assign primary field data when auto id enabled")
common.CheckErr(t, errInsert, false, "invalid parameter")

// flush and check row count
errFlush := mc.Flush(ctx, collName, false)
Expand Down
4 changes: 2 additions & 2 deletions test/testcases/upsert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ func TestUpsertAutoID(t *testing.T) {
// upsert without pks
_, floatColumn1, vecColumn1 := common.GenDefaultColumnData(0, 100, common.DefaultDim)
_, err := mc.Upsert(ctx, collName, "", floatColumn1, vecColumn1)
common.CheckErr(t, err, false, "upsert can not assign primary field data when auto id enabled")
common.CheckErr(t, err, false, "invalid parameter")

// upsert with pks
pkColumn := entity.NewColumnInt64(common.DefaultIntFieldName, ids.(*entity.ColumnInt64).Data()[:100])
_, err = mc.Upsert(ctx, collName, "", pkColumn, floatColumn1, vecColumn1)
common.CheckErr(t, err, false, "upsert can not assign primary field data when auto id enabled")
common.CheckErr(t, err, true)
}

func TestUpsertVarcharPk(t *testing.T) {
Expand Down

0 comments on commit 869db52

Please sign in to comment.