FIX: Events should now be sent to Google Analytics properly from a co…

…nversion
milkyway-multimedia · Jun 22, 2015 · 15f88db · 15f88db
1 parent bdb1bcf
commit 15f88db
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/javascript/conversion-tracker.js b/javascript/conversion-tracker.js
@@ -42,11 +42,17 @@
                             EA.conversion(data);
 
                             if(data.hasOwnProperty('_trackEvent')) {
-                                window.EA.event({
+                                var eventDetails = {
+                                    hitType: 'event',
                                     eventCategory: data._trackEvent.category ? data._trackEvent.category : currentEvent,
                                     eventAction: data._trackEvent.action ? data._trackEvent.action : '',
                                     eventLabel: data._trackEvent.label ? data._trackEvent.label : window.location.href
-                                });
+                                };
+
+                                if(data._defaults.value)
+                                    eventDetails.eventValue = data._defaults.value;
+
+                                window.EA.event(eventDetails);
                             }
                         }, once);
                     }(EA.conversion_trackers[type], events[i]));

diff --git a/javascript/core.track.js b/javascript/core.track.js
@@ -1,6 +1,6 @@
 EA = (function (ea) {
-    if(!ea.hasOwnProperty('eventTriggers'))
-        ea.eventTriggers = {};
+    if(!EA.hasOwnProperty('eventTriggers'))
+        EA.eventTriggers = {};
 
     ea.event = function(details, except) {
         if(!except || except.constructor !== Array) {

diff --git a/javascript/google-analytics.track.init.ss.js b/javascript/google-analytics.track.init.ss.js
@@ -11,7 +11,10 @@ EA.GA.trackers = (function (trackers) {
         initCallbacks:  {},
         hitCallback:    function(){},
         sendEvent:      function(data) {
-                {$Var}('send', data);
+            if(!data.hasOwnProperty('hitType'))
+                data.hitType = 'event';
+
+            {$Var}('send', data);
         }
     };