-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Récupérer données et jumeler les étudiants à leurs superviseurs [SARC-128] #63
Conversation
|
||
LD_users = [process_user(D_user_raw) for D_user_raw in LD_users_raw] | ||
def get_ldap_collection(cfg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourrait être remplacé par quelque chose dans le genre: https://github.com/mila-iqia/SARC/blob/master/sarc/jobs/job.py#L194-L197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into it and it is not trivial, I think it warrants it own ticket to talk about if we want to remove some of the options that are currently provided.
- Currently we can select a database and collection, this would go away of hardcode the collection inside AbstractRepository
- Currently we are doing an efficient bulk insert/update, this would also go away with a single update per user
Co-authored-by: Xavier Bouthillier <[email protected]>
Co-authored-by: Xavier Bouthillier <[email protected]>
Co-authored-by: Xavier Bouthillier <[email protected]>
Co-authored-by: Xavier Bouthillier <[email protected]>
Co-authored-by: Xavier Bouthillier <[email protected]>
Co-authored-by: Xavier Bouthillier <[email protected]>
Intégration du matching dans la fonction sarc.ldap.read_mila_ldap.run.
Le script devrait tenter le matching entre étudiant et superviseur automatiquement.
Si un étudiant est dans 2 mailings lists, le professeur qui est ‘core’ est choisi comme superviseur principale et l’autre comme co-superviseur.
Si l'étudiant a déjà un superviseur dans la DB, on tente le matching tout de même au cas où l'étudiant aurait pu changer de superviseur.