Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Récupérer données et jumeler les étudiants à leurs superviseurs [SARC-128] #63

Merged
merged 46 commits into from
Jul 19, 2023

Conversation

Delaunay
Copy link
Collaborator

@Delaunay Delaunay commented Jul 11, 2023

  • Intégration du matching dans la fonction sarc.ldap.read_mila_ldap.run.

  • Le script devrait tenter le matching entre étudiant et superviseur automatiquement.

    • Si l'étudiant n’est dans aucune mailing list de prof, le champ superviseur est laissé à None,
    • ET l'étudiant est ajouté à une liste à imprimer à la fin de la procédure:
      • Student supervisors to verify: {student mila.quebec emails}.
  • Si un étudiant est dans 2 mailings lists, le professeur qui est ‘core’ est choisi comme superviseur principale et l’autre comme co-superviseur.

    • Sinon, ajouter l'étudiant dans une liste à imprimer à la fin de la procédure:
      • Student co-supervisors to verify: {student mila.quebec emails}.
  • Si l'étudiant a déjà un superviseur dans la DB, on tente le matching tout de même au cas où l'étudiant aurait pu changer de superviseur.

@Delaunay Delaunay marked this pull request as ready for review July 12, 2023 15:03
Pierre Delaunay added 3 commits July 12, 2023 11:11
@Delaunay Delaunay changed the title Issue sarc128 Récupérer données et jumeler les étudiants à leurs superviseurs [SARC-128] Jul 12, 2023
@Delaunay Delaunay requested review from nurbal and bouthilx July 12, 2023 15:25
sarc/config.py Outdated Show resolved Hide resolved
sarc/ldap/acquire.py Outdated Show resolved Hide resolved

LD_users = [process_user(D_user_raw) for D_user_raw in LD_users_raw]
def get_ldap_collection(cfg):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourrait être remplacé par quelque chose dans le genre: https://github.com/mila-iqia/SARC/blob/master/sarc/jobs/job.py#L194-L197

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into it and it is not trivial, I think it warrants it own ticket to talk about if we want to remove some of the options that are currently provided.

  • Currently we can select a database and collection, this would go away of hardcode the collection inside AbstractRepository
  • Currently we are doing an efficient bulk insert/update, this would also go away with a single update per user

tests/exceptions.json Outdated Show resolved Hide resolved
tests/group_to_prof.json Outdated Show resolved Hide resolved
tests/sarc-test.json Outdated Show resolved Hide resolved
scripts/launch_mongod.sh Outdated Show resolved Hide resolved
Pierre Delaunay added 2 commits July 19, 2023 09:07
@mila-iqia mila-iqia deleted a comment from Delaunay Jul 19, 2023
@nurbal nurbal merged commit b1d9676 into master Jul 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants