Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SARC-187 - Provide a prompt for mila-drac manual matching. #61

Merged
merged 10 commits into from
Jul 27, 2023
Merged

SARC-187 - Provide a prompt for mila-drac manual matching. #61

merged 10 commits into from
Jul 27, 2023

Commits on Jul 26, 2023

  1. SARC-187 - Provide a prompt for mila-drac manual matching.

    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    97755a6 View commit details
    Browse the repository at this point in the history

  2. Move prompt logic in a separate function.

    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e2fecfb View commit details
    Browse the repository at this point in the history

  3. Simplify _prompt_manual_match and add unit tests for this function

    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9d5aca9 View commit details
    Browse the repository at this point in the history

  4. Rename and update _matching_names_with_prompt() to _matching_names() … 

    …to use it even without prompt.
    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    89d1f01 View commit details
    Browse the repository at this point in the history

  5. Fix rebasing.

    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    59f8b9d View commit details
    Browse the repository at this point in the history

  6. Fix unit test.

    @notoraptor
    notoraptor committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f7f5b4c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Remove irrelevant doc and.

    @notoraptor
    notoraptor committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    be91bf7 View commit details
    Browse the repository at this point in the history

  2. Save manual matches in a JSON file.

    @notoraptor
    notoraptor committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    cfd3b87 View commit details
    Browse the repository at this point in the history

  3. Extend unit test to check that new manual matches are indeed saved in… 

    … JSON file.
    @notoraptor
    notoraptor committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c51b67b View commit details
    Browse the repository at this point in the history

  4. Fix unit tests.

    @notoraptor
    notoraptor committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a0b521e View commit details
    Browse the repository at this point in the history