Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo via memory #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Mongo via memory #3

wants to merge 8 commits into from

Conversation

PoslinskiNet
Copy link
Collaborator

@PoslinskiNet PoslinskiNet commented Sep 11, 2018 •
edited
Loading

Tasks:

  • Jest test setup
  • Mock ./database via jest
  • Improve Table spec
  • Setup travis

@PoslinskiNet PoslinskiNet added the enhancement New feature or request label Sep 11, 2018
mikoscz
mikoscz requested changes Sep 11, 2018
View reviewed changes
tests/api/v1/tables.test.js Outdated
afterEach(() => {
server.close();
});

describe('tables', () => {
describe('#index', () => {
test('returns all tables', async () => {
const firstTable = await Table.create({
"name": "First table",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name" -> name ✂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thame same for other keys

package.json Outdated
@@ -4,7 +4,7 @@
"description": "",
"main": "index.js",
"scripts": {
"test": "jest",
"test": "MONGODB_URI=mongodb://localhost:27017/lemme-api jest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this env? I saw that this uri is hardcoded inside tests/globalConfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikoscz mikoscz mikoscz requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mikoscz mikoscz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoslinskiNet @mikoscz