Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first root dir by default for ts service client #186812

Closed
wants to merge 2 commits into from

Conversation

nthh
Copy link

@nthh nthh commented Jul 1, 2023

Introduced by #183688
Fixes #186811
@mjbvz

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 18, 2023

I'm unable to reproduce the original issue

Screenshot 2023-07-18 at 11 48 39 AM

I am also not sure this is the right fix. Instead we can try looking up the real workspace for the notebook using getWorkspaceFolder or by working backwards from the cell to the notebook and then to the workspace

@mjbvz mjbvz closed this Jul 18, 2023
@nthh nthh deleted the ts-service-root-uri branch July 25, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS Server not working for Typescript notebooks
2 participants