-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux - display maven and gradle dependencies with pattern 'groupId:artifactId:version ' #859
base: main
Are you sure you want to change the base?
Conversation
Hi @jdneo , this is my view of the implementation for #857, though I am not fully satisfied with changes, as I had to introduce getLabel() method to ExplorerNode. It seems that this only works for Maven, as when gradle project is loaded, the jdtls is not recognizing dependencies as Gradle, instead it is. :/ Could you please take a look and let me know what I might have done better? Also, is there a requirement to test his functionality? |
@microsoft-github-policy-service agree |
@@ -34,6 +34,10 @@ export class PrimaryTypeNode extends DataNode { | |||
return ""; | |||
} | |||
|
|||
public getLabel(): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of introducing getLabel()
into all different types. What about directly set the displayName at java side?
This MR referes to the issue, #857