ux - display maven and gradle dependencies with pattern 'groupId:artifactId:version ' #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jdneo , this is my view of the implementation for #857, though I am not fully satisfied with changes, as I had to introduce getLabel() method to ExplorerNode. It seems that this only works for Maven, as when gradle project is loaded, the jdtls is not recognizing dependencies as Gradle, instead it is. :/ Could you please take a look and let me know what I might have done better? Also, is there a requirement to test his functionality? |
jdneo
reviewed
Oct 16, 2024
jdneo
reviewed
Oct 17, 2024
mamilic
commented
Oct 18, 2024
|
@microsoft-github-policy-service agree |
jdneo
reviewed
Oct 22, 2024
jdneo
reviewed
Oct 22, 2024
jdneo
reviewed
Oct 23, 2024
jdneo
reviewed
Oct 23, 2024
| @@ -34,6 +34,10 @@ export class PrimaryTypeNode extends DataNode { | |||
| return ""; | |||
| } | |||
|
|
|||
| public getLabel(): string { | |||
There was a problem hiding this comment.
Instead of introducing getLabel() into all different types. What about directly set the displayName at java side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR referes to the issue, #857