Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wiki guide for API Catalog #272

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feat: add wiki guide for API Catalog #272

merged 5 commits into from
Oct 22, 2024

Conversation

wenytang-ms
Copy link
Contributor

@wenytang-ms wenytang-ms commented Oct 17, 2024

image

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.07%. Comparing base (1721269) to head (283cda1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/extension.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #272      +/-   ##
==========================================
+ Coverage   45.96%   46.07%   +0.11%     
==========================================
  Files          92       92              
  Lines        5826     5840      +14     
  Branches      141      142       +1     
==========================================
+ Hits         2678     2691      +13     
- Misses       3146     3147       +1     
  Partials        2        2              
Files with missing lines Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/tree/DataPlaneAccount.ts 67.93% <100.00%> (+3.47%) ⬆️
src/uiStrings.ts 100.00% <100.00%> (ø)
src/extension.ts 0.00% <0.00%> (ø)

Copy link
Member

@formulahendry formulahendry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we consider also adding a 'learnApiCatalog' item in Tree View when it is empty in Tree View?

@wenytang-ms
Copy link
Contributor Author

Shall we consider also adding a 'learnApiCatalog' item in Tree View when it is empty in Tree View?
@formulahendry please help review again

@wenytang-ms wenytang-ms merged commit a328802 into dev Oct 22, 2024
10 of 11 checks passed
@wenytang-ms wenytang-ms deleted the wenyt/wiki branch October 22, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants