feat: update per API change for importing ruleset #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 40.86% 41.71% +0.85%
==========================================
Files 81 81
Lines 4860 4921 +61
Branches 111 125 +14
==========================================
+ Hits 1986 2053 +67
+ Misses 2873 2867 -6
Partials 1 1
|
wenytang-ms
reviewed
Aug 6, 2024
wenytang-ms
reviewed
Aug 6, 2024
wenytang-ms
reviewed
Aug 6, 2024
| do { | ||
| response = await client.sendRequest(options); | ||
| if (response.parsedBody?.status === "Succeeded") { | ||
| return { isSuccessful: true }; |
There was a problem hiding this comment.
the response no need to return?
There was a problem hiding this comment.
Just return ApiCenterRulesetImportResult
adashen
reviewed
Aug 6, 2024
| url: location, | ||
| }; | ||
|
|
||
| const timeout = 30000; // 30 seconds in milliseconds |
There was a problem hiding this comment.
Do we consider use retry times like 5 times? Or the service team recommend to use timeout?
There was a problem hiding this comment.
The 'importing spec' written by service team used this pattern, so I just follow it.
There was a problem hiding this comment.
Just synced with Alex yesterday, he recommand to set timeout as 60 seconds, as the job may be long.
wenytang-ms
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.