Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: store selected tenant #213

Merged
merged 3 commits into from
Jul 25, 2024
Merged

perf: store selected tenant #213

merged 3 commits into from
Jul 25, 2024

Conversation

wenytang-ms
Copy link
Contributor

@wenytang-ms wenytang-ms commented Jul 23, 2024

Animation

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (7728311) to head (2acb835).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
+ Coverage   44.71%   45.47%   +0.76%     
==========================================
  Files          80       81       +1     
  Lines        5119     5163      +44     
  Branches      177      182       +5     
==========================================
+ Hits         2289     2348      +59     
+ Misses       2829     2814      -15     
  Partials        1        1              
Files Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
...rc/test/unit/azure/azureLogin/azureAccount.test.ts 100.00% <100.00%> (ø)
src/azure/azureLogin/azureAccount.ts 31.57% <72.72%> (+11.86%) ⬆️
src/azure/azureLogin/azureSessionProvider.ts 32.38% <12.50%> (+3.55%) ⬆️

@wenytang-ms wenytang-ms marked this pull request as ready for review July 23, 2024 05:44
@wenytang-ms wenytang-ms changed the title feat: store selected tenant perf: store selected tenant Jul 24, 2024
Copy link
Member

@adashen adashen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is stored in workspace setting. When there is no workspace opened, what will happen?

@wenytang-ms wenytang-ms reopened this Jul 25, 2024
@wenytang-ms
Copy link
Contributor Author

The value is stored in workspace setting. When there is no workspace opened, what will happen?

this is an method from vscode.workspace interface, the configuration is a global settings for user.
If user open vscode without a workspace or project, it also works, since it read from user's settings file for vscode. it has nothing to do with the user's workspace or project.

@wenytang-ms wenytang-ms merged commit 9d15426 into dev Jul 25, 2024
15 checks passed
@wenytang-ms wenytang-ms deleted the wenyt/account branch July 25, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants