Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[turbobase64] update to 2023.08 #41748

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
+21 −81
Draft

[turbobase64] update to 2023.08 #41748

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddeb916
[turbobase64] update to 2023.08
Cheney-W Oct 24, 2024
ff64643
Modify ci.baseline.txt
Cheney-W Oct 24, 2024
e4c9131
Add support
Cheney-W Oct 24, 2024
b4f6fbc
Modify
Cheney-W Oct 24, 2024
02c03eb
Use version
Cheney-W Oct 25, 2024
1fddb29
Update turbobase64.json
Cheney-W Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 0 additions & 66 deletions ports/turbobase64/CMakeLists.txt
View file
Open in desktop

This file was deleted.

19 changes: 10 additions & 9 deletions ports/turbobase64/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO powturbo/Turbo-Base64
REF 95ba56a9b041f9933f5cd2bbb2ee4e083468c20a
SHA512 bacab8ede5e20974207e01c13a93e6d8afc8d08bc84f1da2b6efa1b4d17408cef6cea085e209a8b7d3b2e2a7223a785f8c76aa954c3c787e9b8d891880b63606
HEAD_REF master
OUT_SOURCE_PATH SOURCE_PATH
REPO powturbo/Turbo-Base64
REF ${VERSION}
SHA512 de8aaace0faf6552cf692f131a4d03882b88252732bb4160c48e5cc630a0c2f637fa27309e084d02305cdf7ef28020e6c9fbb82b50c1916e46aabc95baea75ad
HEAD_REF master
)

file(COPY "${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt" DESTINATION "${SOURCE_PATH}")

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
SOURCE_PATH "${SOURCE_PATH}"
)

vcpkg_cmake_install()

vcpkg_cmake_config_fixup(PACKAGE_NAME "unofficial-${PORT}")
vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/${PORT}")

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")

vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
5 changes: 2 additions & 3 deletions ports/turbobase64/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
{
"name": "turbobase64",
"version-date": "2020-01-12",
"port-version": 3,
"version-string": "2023.08",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use version-string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The version field does not support values like 2023.08 and will throw an error.
  2. 2023.08 also does not fall within the scope of the version-semver field.
  3. Since the upstream has already released tags like 2023.08, using version-date would not be appropriate.

This is why I chose to use version-string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version field does not support values like 2023.08 and will throw an error.

I know.

2023.08 also does not fall within the scope of the version-semver field.

I know.

Since the upstream has already released tags like 2023.08, using version-date would not be appropriate.

I disagree. Exact version-string is worse than omitting leading zeros in version.

This is not a unique problem. We do have several ports which suffer from point 1. Still, we use version because it allows for >=, and we transform VERSION to the desired tag. Example: poppler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your patient guidance.

"description": "Fastest Base64 SIMD/Neon library",
"homepage": "https://github.com/powturbo/Turbo-Base64",
"license": "GPL-3.0-only",
"supports": "!windows",
"supports": "!android & !(windows & arm)",
"dependencies": [
{
"name": "vcpkg-cmake",
Expand Down
1 change: 0 additions & 1 deletion scripts/ci.baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,6 @@ torch-th:arm64-uwp=fail
torch-th:x64-android=fail
torch-th:x64-uwp=fail
torch-th:x64-windows-static=fail
turbobase64:arm-neon-android=fail
tvision:arm-neon-android=fail
tvision:arm64-android=fail
tvision:x64-android=fail
Expand Down
4 changes: 2 additions & 2 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9109,8 +9109,8 @@
"port-version": 0
},
"turbobase64": {
"baseline": "2020-01-12",
"port-version": 3
"baseline": "2023.08",
"port-version": 0
},
"tvision": {
"baseline": "2024-05-22",
Expand Down
5 changes: 5 additions & 0 deletions versions/t-/turbobase64.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "b272b78b303a27c801164de8c9d13cf89efc0258",
"version-string": "2023.08",
"port-version": 0
},
{
"git-tree": "20d23821ef39944689c9ec0e8cf02d17c7b68901",
"version-date": "2020-01-12",
Expand Down
Loading