[turbobase64] update to 2023.08 #41748
Draft
+21
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
info:internal
dg0yt
reviewed
Oct 24, 2024
ports/turbobase64/vcpkg.json
Outdated
| @@ -1,11 +1,10 @@ | |||
| { | |||
| "name": "turbobase64", | |||
| "version-date": "2020-01-12", | |||
| "port-version": 3, | |||
| "version-string": "2023.08", | |||
There was a problem hiding this comment.
- The
versionfield does not support values like2023.08and will throw an error. 2023.08also does not fall within the scope of theversion-semverfield.- Since the upstream has already released tags like
2023.08, usingversion-datewould not be appropriate.
This is why I chose to use version-string.
There was a problem hiding this comment.
The
versionfield does not support values like2023.08and will throw an error.
I know.
2023.08also does not fall within the scope of theversion-semverfield.
I know.
Since the upstream has already released tags like
2023.08, usingversion-datewould not be appropriate.
I disagree. Exact version-string is worse than omitting leading zeros in version.
This is not a unique problem. We do have several ports which suffer from point 1. Still, we use version because it allows for >=, and we transform VERSION to the desired tag. Example: poppler.
There was a problem hiding this comment.
Thank you very much for your patient guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41724
Use the upstream provided CMakeLists.txt and fix the usage issues
Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.