-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[turbobase64] update to 2023.08 #41748
base: master
Are you sure you want to change the base?
Conversation
ports/turbobase64/vcpkg.json
Outdated
@@ -1,11 +1,10 @@ | |||
{ | |||
"name": "turbobase64", | |||
"version-date": "2020-01-12", | |||
"port-version": 3, | |||
"version-string": "2023.08", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use version-string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
version
field does not support values like2023.08
and will throw an error. 2023.08
also does not fall within the scope of theversion-semver
field.- Since the upstream has already released tags like
2023.08
, usingversion-date
would not be appropriate.
This is why I chose to use version-string
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
version
field does not support values like2023.08
and will throw an error.
I know.
2023.08
also does not fall within the scope of theversion-semver
field.
I know.
Since the upstream has already released tags like
2023.08
, usingversion-date
would not be appropriate.
I disagree. Exact version-string
is worse than omitting leading zeros in version
.
This is not a unique problem. We do have several ports which suffer from point 1. Still, we use version
because it allows for >=
, and we transform VERSION
to the desired tag. Example: poppler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your patient guidance.
Fixes #41724
Use the upstream provided CMakeLists.txt and fix the usage issues
Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.