Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scrolling in Minecraft HOC Tutorial View #10235

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fix Scrolling in Minecraft HOC Tutorial View #10235

merged 6 commits into from
Oct 17, 2024

Commits on Oct 16, 2024

  1. Handle resizing the tutorial card using height: auto instead of spe… 

    …cific numbers plus a hardcoded threshold. Also change how we determine if we need to show the more/less toggle, so it's now based on the initial size as a "default" and not just the latest current size, which leads to inconistent behavior.
    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    004bca8 View commit details
    Browse the repository at this point in the history

  2. Clean up long class list for tutorialCard.

    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    914314b View commit details
    Browse the repository at this point in the history

  3. Refactor the "get interior height" code into separate function

    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0e8d0a5 View commit details
    Browse the repository at this point in the history

  4. Move less/more button to the left when toolbox is hidden (it's just e… 

    …mpty space, vs overlapping the undo/redo buttons).
    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    85b4885 View commit details
    Browse the repository at this point in the history

  5. Tidying & commenting

    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f030c23 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary css (not needed now that there's a ":not(.hideTool… 

    …box)" in the case above)
    @thsparks
    thsparks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6f2ca16 View commit details
    Browse the repository at this point in the history