Fix simx path formatting issue #10229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
approved these changes
Oct 11, 2024
eanders-ms
added a commit
that referenced
this pull request
Oct 11, 2024
* fix path formatting issue * simpler fix * restore comment
eanders-ms
added a commit
that referenced
this pull request
Oct 11, 2024
* Support for 3rd-party simulator extensions (#10213) * support for simulator extensions * lint * lint * n * restore * restore * read * wording * simxdevmode * add test simx * async componentDidMount * `e` -> `x` * Add simulator extension doc page (#10219) * support for simulator extensions * lint * lint * n * restore * restore * read * wording * simxdevmode * add test simx * async componentDidMount * `e` -> `x` * update docs * simulator extensions: apply aspect ratio to simx iframe (#10222) * apply simx aspect ratio * lint * sanitizeCssName * Fix simx path formatting issue (#10229) * fix path formatting issue * simpler fix * restore comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The foundation folks identified a case where the simulator extension URL could be incorrect.
cc: @microbit-matt-hillsdon @microbit-robert