Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teacher Tool: Change block display #10202

Merged
merged 34 commits into from
Sep 26, 2024
Merged

Teacher Tool: Change block display #10202

merged 34 commits into from
Sep 26, 2024

Commits on Sep 13, 2024

  1. In progress still getting things working...

    @thsparks
    thsparks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    be86d7c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Some display changes

    @thsparks
    thsparks committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    30dff95 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'master' of https://github.com/microsoft/pxt into thspar… 

    …ks/teachertool/change_block_display
    @thsparks
    thsparks committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a5f5c7a View commit details
    Browse the repository at this point in the history

  2. TIdy code

    @thsparks
    thsparks committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fc0c083 View commit details
    Browse the repository at this point in the history

  3. Attempt to handle blocks with no "parts" attribute. Seems like these … 

    …blocks are defined a bit differently in blocks.ts and/or blockSnippets.ts? Idk this doesn't feel like a good solution...
    @thsparks
    thsparks committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ae159cd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'master' of https://github.com/microsoft/pxt into thspar… 

    …ks/teachertool/change_block_display
    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9763e5b View commit details
    Browse the repository at this point in the history

  2. Comment update

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8af2714 View commit details
    Browse the repository at this point in the history

  3. Refactor getBlockReadableName to getReadableBlockName

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8bce495 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/microsoft/pxt into thspar… 

    …ks/teachertool/change_block_display
    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    466d31d View commit details
    Browse the repository at this point in the history

  5. Cache readable block names

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    12739c2 View commit details
    Browse the repository at this point in the history

  6. Move getBlockDescription and getSnippetName into new file

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7768d0e View commit details
    Browse the repository at this point in the history

  7. ReadableBlockName -> BlockTextParts

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2290097 View commit details
    Browse the repository at this point in the history

  8. Move getBlockTextPartsFromBlocksBlockDefinition into helpers

    @thsparks
    thsparks committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f974f56 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Refactor monacoFlyout to use shared getBlockTextParts function

    @thsparks
    thsparks committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ab84d3d View commit details
    Browse the repository at this point in the history

  2. Don't cache for now (just because I need it uncached for testing)

    @thsparks
    thsparks committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b74e8ba View commit details
    Browse the repository at this point in the history

  3. Replace all params with value

    @thsparks
    thsparks committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    df4b703 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Add snippet names for blocks

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    944acd7 View commit details
    Browse the repository at this point in the history

  2. Use snippet names as fallback

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c131bfb View commit details
    Browse the repository at this point in the history

  3. Styling adjustments

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6bf02b1 View commit details
    Browse the repository at this point in the history

  4. Different name for the square root (and other operations) block. I st… 

    …ruggled to figure out what to call this one, opted for the simplest approach which is just to include a subset of the options in it. Don't love this, but doing it for now until I can think of something better.
    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7799b36 View commit details
    Browse the repository at this point in the history

  5. Re-include caching logic

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7b5a829 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary code movement change

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d228a56 View commit details
    Browse the repository at this point in the history

  7. Minor code cleanup

    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dbe3493 View commit details
    Browse the repository at this point in the history

  8. Only rely on blockId (not blockData) to display the readable componen… 

    …t. This way we don't have to wait for the toolbox info to display cached results.
    @thsparks
    thsparks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    39a8500 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Clean up code in app.tsx

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1de0863 View commit details
    Browse the repository at this point in the history

  2. Do not show duplicate names

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b19ddac View commit details
    Browse the repository at this point in the history

  3. Remove shared use of getSnippetName. It was causing more complexity t… 

    …han it removed.
    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d0f5fa0 View commit details
    Browse the repository at this point in the history

  4. Update some block snippets

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fbeefda View commit details
    Browse the repository at this point in the history

  5. blockTextParts -> blockAsText

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cae7c4d View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary newline

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d6673d8 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5e56afc View commit details
    Browse the repository at this point in the history

  8. Prettier

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0ba72f2 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary Promise.resolve

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    52da0b9 View commit details
    Browse the repository at this point in the history

  10. Use var for shadow color

    @thsparks
    thsparks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2864ed9 View commit details
    Browse the repository at this point in the history