[Stable8.5] Port time machine to arcade stable #10184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we try to do the entire release instead of just porting this? |
|
@abchatra eh, that makes me a bit more nervous because of the blockly change. arcade has all of the asset stuff in blocks which is much more complicated than anything in the micro:bit or minecraft editors... i think i'll switch to using beta on stream next week to get some more testing/validation in. if it's looking good, then yeah i say we do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports time machine to arcade's stable branch of pxt-core.
I had to do this by hand because stable8.5 doesn't have the change where pxteditor got converted into modules. That being said, it was a very easy merge since most of this code is new/self contained. This includes all of the various fixes I've made.
Below is an upload target link that is based off of the stable1.12 branch of pxt-arcade (the current live version). The only change between this and live is the time machine code in this PR.
https://arcade.makecode.com/app/c1ced1df4e6cf7b38de44793fc64173aa2a8ab89-95b1257bf1