Code eval tool: make exporting available without a project #10150
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Agree about your comments about export being confusing. We saw it in our user testing too. We'll need to chat a bit more as a team to decide how we want to present it. Personally, I think it should be moved out of the top bar altogether, just not sure yet where to move it to...
Not something to block this change, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#5900
Also curious if we should add a bit more detail in the tooltips for the action buttons.. It seems a bit funky to me that exporting gives me a JSON representation of the checklist and printing gives me exactly what's on the page. As a user, I think I would expect the export and print to give me the same thing or, that exporting would give me the option for file types.
I'm totally fine with leaving as is, but wanted to have a discussion about it. If we did want to add a bit more explanation, I was thinking of, for export tooltip: "Export checklist JSON for reimport" and then keep print the same. Another option could be rename "Export" to "Save" so that it's a bit clearer that we're giving the export functionality so a user doesn't lose their progress when making a checklist. Let me know what you think.