Remove unnecessary code movement change

microsoft · Sep 24, 2024 · d228a56 · d228a56
1 parent 7b5a829
commit d228a56
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/teachertool/src/components/CriteriaInstanceDisplay.tsx b/teachertool/src/components/CriteriaInstanceDisplay.tsx
@@ -146,6 +146,15 @@ interface BlockData {
 const BlockInputSegment: React.FC<BlockInputSegmentProps> = ({ instance, param }) => {
     const { state: teacherTool } = useContext(AppStateContext);
 
+    function handleClick() {
+        pxt.tickEvent(Ticks.BlockPickerOpened, { criteriaCatalogId: instance.catalogCriteriaId });
+        showModal({
+            modal: "block-picker",
+            criteriaInstanceId: instance.instanceId,
+            paramName: param.name,
+        } as BlockPickerOptions);
+    }
+
     const blockData = useMemo<BlockData | undefined>(() => {
         if (!param.value || !teacherTool.toolboxCategories) {
             return undefined;
@@ -161,15 +170,6 @@ const BlockInputSegment: React.FC<BlockInputSegmentProps> = ({ instance, param }
         return undefined;
     }, [param.value, teacherTool.toolboxCategories]);
 
-    function handleClick() {
-        pxt.tickEvent(Ticks.BlockPickerOpened, { criteriaCatalogId: instance.catalogCriteriaId });
-        showModal({
-            modal: "block-picker",
-            criteriaInstanceId: instance.instanceId,
-            paramName: param.name,
-        } as BlockPickerOptions);
-    }
-
     const style = blockData ? { backgroundColor: blockData.category.color, color: "white" } : undefined;
     const blockDisplay = blockData ? <ReadableBlockName blockData={blockData} /> : null;
     return (