Skip to content

Commit

Permalink
Protect against undefined values in string validation.
Browse files Browse the repository at this point in the history
  • Loading branch information
thsparks committed Sep 11, 2024
1 parent 43cd8bf commit 108a2ba
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions teachertool/src/types/criteriaParameters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ export class BaseStringParameter extends CriteriaParameter {
}

override validate(value: string): CriteriaParameterValidationResult {
if (!value?.trim()) {
return { valid: false, message: Strings.ValueRequired };
}
if (!value) return { valid: true }; // Unset is okay for initial value

if (this.maxCharacters && value.length > this.maxCharacters) {
return { valid: false, message: Strings.ExceedsMaxLength };
}
Expand Down

0 comments on commit 108a2ba

Please sign in to comment.