Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assembly resolve behavior #358

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented Aug 15, 2024

Fixes: #286

  • Update the resolving event to separate the functionality of resolving an assembly from dynamically exporting an assembly's types.
  • Search .NET system directories (Microsoft.NETCore.App, Microsoft.AspNetCore.App, and Microsoft.WindowsDesktop.App if present) when resolving assemblies, before raising the resolving event.
  • Search directories of already-resolved assemblies when an assembly is not resolved by the resolving event listener.
  • Defer dynamic export of System.Runtime and System.Console assembly types until the first time the dotnet.System property is accessed from JavaScript. This significantly improves startup time for scenarios that do not use dynamic export.
  • Bump version to 0.8

@jasongin jasongin requested a review from vmoroz August 15, 2024 00:40
@jasongin jasongin merged commit a1ef423 into main Aug 15, 2024
24 checks passed
@jasongin jasongin deleted the dev/jasongin/assembly-resolve branch August 15, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node runtime error when working with DependencyInjection
2 participants