Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape reserved words in generated typedefs #357

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

jasongin
Copy link
Member

Fixes: #341
Fixes: #343

  • When generating typedefs, prepend _ to any parameter names that are reserved keywords in JS/TS.
  • Add NodeApiTypeDefinitionsEnableWarnings MSBuild property and suppress typedef generator warnings by default.

@jasongin jasongin requested a review from vmoroz August 14, 2024 06:17
@jasongin jasongin merged commit 6ffa6a2 into main Aug 14, 2024
24 checks passed
@jasongin jasongin deleted the dev/jasongin/tsgen branch August 14, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants