Fix source-generator bug for constructor with circular type reference (…

…#174)
microsoft · Nov 10, 2023 · 248214d · 248214d
1 parent 8a26082
commit 248214d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/NodeApi.Generator/SymbolExtensions.cs b/src/NodeApi.Generator/SymbolExtensions.cs
@@ -352,7 +352,7 @@ private static void BuildSymbolicTypeMembers(
             if (memberSymbol is IMethodSymbol constructorSymbol &&
                 constructorSymbol.MethodKind == MethodKind.Constructor)
             {
-                BuildSymbolicConstructor(typeBuilder, constructorSymbol);
+                BuildSymbolicConstructor(typeBuilder, constructorSymbol, genericTypeParameters);
             }
             else if (memberSymbol is IMethodSymbol methodSymbol &&
                 (methodSymbol.MethodKind == MethodKind.Ordinary ||
@@ -391,14 +391,17 @@ private static void BuildSymbolicTypeMembers(
     }
 
     private static ConstructorBuilder BuildSymbolicConstructor(
-        TypeBuilder typeBuilder, IMethodSymbol constructorSymbol)
+        TypeBuilder typeBuilder,
+        IMethodSymbol constructorSymbol,
+        Type[]? genericTypeParameters)
     {
         bool isDelegateConstructor = typeBuilder.BaseType == typeof(MulticastDelegate);
         ConstructorBuilder constructorBuilder = typeBuilder.DefineConstructor(
             MethodAttributes.Public | (isDelegateConstructor ?
                 MethodAttributes.RTSpecialName | MethodAttributes.HideBySig : default),
             CallingConventions.HasThis,
-            constructorSymbol.Parameters.Select((p) => p.Type.AsType()).ToArray());
+            constructorSymbol.Parameters.Select(
+                (p) => p.Type.AsType(genericTypeParameters)).ToArray());
 
         IReadOnlyList<IParameterSymbol> parameters = constructorSymbol.Parameters;
         for (int i = 0; i < parameters.Count; i++)