Use distpack to create archives #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Sienkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-distpackto create the tar.gz and zip archives of our builds #912Remove our own code to create build/source archives and use upstream's distpack tool instead.
distpack only works when a VERSION file is present (release branches), but we build
microsoft/maintracking upstreammaster, which doesn't have a VERSION. In this case, I generate a temp VERSION file. This results in local outputs like:I tested a build with the submodule set to 1.21rc3 without any patches, and the local build produced:
There was no file diff vs. upstream's build on go.dev/dl. After adding patches, only the source files we added showed up in the file diff.
This change adds the AzDO build number (locally,
dev) so we don't end up with the same tar.gz name for multiple builds that use the same submodule commit. This isn't important for our own infra to work properly, but other infra might cache our artifacts based on filename and it's worth adding uniqueness to keep that working. Also, for devs downloading multiple builds to the same download folder over time, it helps differentiate the files without dealing with(1),(2), etc.Latest test build here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2230229&view=results