Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add demo3 and update demo2 text #2268

Closed
wants to merge 68 commits into from

Conversation

bvonodiripsa
Copy link
Contributor

Related Issues/PRs

#Adding GPU based demos (doc)

What changes are proposed in this pull request?

Corrected text in demo2 notebook and adding demo3.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@bvonodiripsa bvonodiripsa changed the title Add demo3 and update demo2 text feat: Add demo3 and update demo2 text Aug 26, 2024
@bvonodiripsa
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (eb309fe) to head (5cda463).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   84.54%   84.43%   -0.11%     
==========================================
  Files         327      327              
  Lines       16775    16773       -2     
  Branches     1499     1511      +12     
==========================================
- Hits        14182    14163      -19     
- Misses       2593     2610      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvonodiripsa
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bvonodiripsa
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bvonodiripsa
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -37,7 +37,7 @@ class OpenAICompletion(override val uid: String) extends OpenAIServicesBase(uid)
s"${getUrl}openai/deployments/${getValue(row, deploymentName)}/completions"
}

override protected[openai] def prepareEntity: Row => Option[AbstractHttpEntity] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove private scoping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants