Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tiny bug fix to avoid KeyError #2264

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Aug 12, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

minor change to fix a KeyError bug that occurs if kwargs is defined but "df" isn't a valid key. .get("df") will return None if "df" doesn't exist, short-circuiting the conditional and avoiding the error.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 changed the title micro: tiny bug fix to avoid KeyError fix: tiny bug fix to avoid KeyError Aug 12, 2024
@sss04
Copy link
Contributor Author

sss04 commented Aug 12, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (72f99c8) to head (30d0218).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
+ Coverage   83.20%   84.42%   +1.21%     
==========================================
  Files         327      327              
  Lines       16775    16775              
  Branches     1499     1499              
==========================================
+ Hits        13958    14162     +204     
+ Misses       2817     2613     -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723 mhamilton723 merged commit eb309fe into microsoft:master Aug 12, 2024
46 of 70 checks passed
@sss04 sss04 deleted the shyamsai/loggerBug branch August 12, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants