Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates issue of 0 value for query_result_dists in search_memory #528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updates issue of 0 value for query_result_dists in search_memory #528

wants to merge 2 commits into from

Conversation

asharani97
Copy link

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

This passes query_result_dists in search() for DiskANN without any filters

Any other comments?

No

@asharani97
Update search_memory_index.cpp
b740611 
Solves 0 values for result_dist for DiskANN
@asharani97
Merge pull request #1 from asharani97/asharani97-patch-1
41ddbd7 
Update search_memory_index.cpp
@asharani97 asharani97 mentioned this pull request Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asharani97