-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The willing api for fixing aggregate returns #74
base: main
Are you sure you want to change the base?
Conversation
include/directx/d3d12.h
Outdated
( (This)->lpVtbl -> GetDesc(This) ) | ||
#define ID3D12DescriptorHeap_GetDesc(This,RetVal) \ | ||
do { \ | ||
*(RetVal) = ( (This)->lpVtbl -> GetDesc(This) ) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it's non-win32, maybe we can use static inline, as linux always using gcc or gcc-compat compilers.
I think support for inline is not a issue for C language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not for mingw, it's for Linux only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with inline function, so they are very consistence now
Using an inline function for C is slightly different compared to the macros. Specifically, this is valid with a macro but not with an inline: ID3D12Resource1 *res;
D3D12_RESOURCE_DESC desc;
ID3D12Resource_GetDesc(res, &desc); With the macro, that calls into This is on my to-do list, to see what can be done in MIDL vs what can be done manually via helper headers externally to MIDL. Note that I'm treating this as low priority though - the important thing is that the D3D12 APIs can be invoked by the various compilers for the various platforms across C and C++ and actually work correctly, even if it requires some |
No description provided.