[TL] initial implement flashattention op in TL #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzj-fxz
commented
Sep 29, 2024
tzj-fxz
commented
- add initial implementation of flashattention in ops/general_flashatten
- wrap implementation in config class and op class
- fix kernel name bug
- modify tilelang test script
- add ops flashattention test script
LeiWang1999
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Thanks for your contributions. @tzj-fxz
I've left some comments.
|
thanks @tzj-fxz ，overall lgtm, should fix the test. |
OK, now CI tests are passed in the newest commit. |
|
Merged, thanks @tzj-fxz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.