Issue 1164 (#1172)

Fixes #1164 --------- Co-authored-by: freddydk <[email protected]>
microsoft · Aug 19, 2024 · a2c4efc · a2c4efc
1 parent 6c58752
commit a2c4efc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Actions/ReadSecrets/ReadSecretsHelper.psm1 b/Actions/ReadSecrets/ReadSecretsHelper.psm1
@@ -26,7 +26,6 @@ function GetAzureCredentials {
     return $null
 }
 
-
 function MaskValue {
     Param(
         [string] $key,
@@ -119,6 +118,16 @@ function GetKeyVaultCredentials {
             $creds = $null
         }
     }
+    if ($creds) {
+        try {
+            # check that we have access to get secrets from the keyvault by trying to get a dummy secret
+            GetKeyVaultSecret -secretName 'algodummysecret' -keyVaultCredentials $creds -encrypted | Out-Null
+        }
+        catch {
+            Write-Host "Unable to get secrets from Azure Key Vault. Error was $($_.Exception.Message). Using Github secrets instead."
+            $creds = $null
+        }
+    }
     return $creds
 }
 

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -10,6 +10,7 @@
 - Fix issue with github ref when running reusable workflows
 - Issue 1098 Support for specifying the name of the AZURE_CREDENTIALS secret by adding a AZURE_CREDENTIALSSecretName setting
 - Fix placeholder syntax for git ref in PullRequestHandler.yaml
+- Issue 1164 Getting secrets from Azure key vault fails in Preview
 
 ### Dependencies to PowerShell modules