Fix percentile metrics rotating too often #5237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change percentile metrics rotation interval was set to `expiry / bufferLength`. This was different from other metrics like `_max` where the interval is set to `expiry`. At the same time documentation of the `expiry` parameter says clearly that it is used as rotation interval. This inconsistent behavior was confusing for users because some metrics expired faster than the others. What's more it caused some requests to be ignored in percentile metrics if `expiry` (also called `step`) was set to the same duration as scrapping interval (e.g. 1 minute) and scrapping occurred not long after buffer rotation. In case of the default config where `bufferLength` is 3 it could result in up to 33% requests being ignored by percentile metrics. Fix this inconsistency by changing buffer rotation interval for percentiles to `expiry`. Fixes micrometer-metrics#3298
|
@rafalh Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@rafalh Thank you for signing the Contributor License Agreement! |
rafalh
force-pushed
the
percentile-expiry-fix
branch
from
9a82cef
to
09e7fba
Compare
rafalh
force-pushed
the
percentile-expiry-fix
branch
from
09e7fba
to
60a3a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change percentile metrics rotation interval was set to
expiry / bufferLength. This was different from other metrics like_maxwhere the interval is set toexpiry. At the same time documentation of theexpiryparameter says clearly that it is used as rotation interval.This inconsistent behavior was confusing for users because some metrics expired faster than the others. What's more it caused some requests to be ignored in percentile metrics if
expiry(also calledstep) was set to the same duration as scrapping interval (e.g. 1 minute) and scrapping occurred not long after buffer rotation. In case of the default config wherebufferLengthis 3 it could result in up to 33% requests being ignored by percentile metrics.Fix this inconsistency by changing buffer rotation interval for percentiles to
expiry.Fixes #3298