update setup.py and fix #95: don't add slashes to void elements #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beautifulsoup 4.6.2 introduced the ability to control the slashes in void elements through formatters. This adds a formatter that does this, but otherwise only does minimal encoding (as the previous, default, formatter did)
sknebel
changed the title
|
concern with this: might break granary: #95 (comment) |
|
per further discussion in #95, granary can handle this by changing to html format in the Atom feeds |
tantek
approved these changes
May 2, 2020
|
looks good to me. Might want to add some tests for this so that we can track any future changes to the code base. |
|
Is there a reason why the |
|
Also: From the BeautifulSoup documentation it looks like they already provide an HTML5 formatter which you get by passing the string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combined with setup.py since it relies on features new to BS4.