Cross product and triple scalar product for all vectors (dense, tiny, engine) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that, the result type was enforced to be DenseVector<Array<T>>. So, neither TinyVector nor different Engine could habe been handled. The current modification aims at making the result type consistent with the input vector types of the closure.
This extension is made for: - asum - dot - iamax - nrm2 - raxpy - rot - rotm Of course, in order to ensure good performance, it may be also necessary to add implementations for these functions into tinylevel1.
- add OpCross struct - add closures to eval y=x1%x2 and y+=x1%x2
This reverts commit 8b47472.
- add OpCross struct - add closures to eval y=x1%x2 and y+=x1%x2
tkloczko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step : modification of type result for vector closure
Before that, the result type was enforced to be DenseVector< Array >.
So, neither TinyVector nor different Engine could have been handled.
The current modification aims at making the result type consistent with the input vector types of the closure.
Second step : extension of blas level1 for tiny vectors
This extension is made for:
Of course, in order to ensure good performance, it may be also necessary to add implementations for these functions into tinylevel1.
Last step : Add cross product and triple scalar product.
It consists in adding: