-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix airnow files with strange file encodings #895
try to fix airnow files with strange file encodings #895
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-dev #895 +/- ##
============================================
- Coverage 79.45% 79.09% -0.36%
============================================
Files 103 103
Lines 17821 17910 +89
============================================
+ Hits 14159 14166 +7
- Misses 3662 3744 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This is till not the final solution because it takes far too much RAM reading the entire dataset since the file reader reads all variables and keeps all that data in RAM. On the other hand the variables are read by aeroval variable by variable so the multi variable reading ability of the current reader is entirely useless. |
Just for documentation: Not even 75GB is enough to read |
…irnow-reader-crashing
Just as comment: The earlier years (rep 2017) will be added as utf-8 encoded files. Producing them is external work. |
…irnow-reader-crashing
…ashing' into griesie-fix-890-airnow-reader-crashing
…irnow-reader-crashing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎃
Another approach:
determine file encoding beforehand and provide pandas with that