Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1339 add pm ratios to EMEP reader; add example config for them #1378

Merged

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Oct 16, 2024

Change Summary

This PR adds two more calculated variables to the EMEP reader:
ratpm10pm25 and ratpm25pm10.
In addition, the aeroval config has been added which is available through
pyaerocom.aeroval.config.pmratios.base_config.get_CFG()

Related issue number

fix #1339

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller added this to the m2024-11 milestone Oct 16, 2024
@jgriesfeller jgriesfeller self-assigned this Oct 16, 2024
@jgriesfeller jgriesfeller linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (28a7cab) to head (61682b8).
Report is 19 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/mscw_ctm/additional_variables.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1378      +/-   ##
============================================
+ Coverage     78.50%   78.53%   +0.03%     
============================================
  Files           136      137       +1     
  Lines         20860    20899      +39     
============================================
+ Hits          16377    16414      +37     
- Misses         4483     4485       +2     
Flag Coverage Δ
unittests 78.53% <94.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review October 17, 2024 08:18
@jgriesfeller jgriesfeller added the documentation 📖 Everything related to code documentation, tutorials and examples label Oct 17, 2024
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorbjoernl thorbjoernl merged commit c258c94 into main-dev Oct 17, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the 1339-add-example-aeroval-configuration-for-pm10pm25-ratio branch October 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Everything related to code documentation, tutorials and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add example aeroval configuration for PM10/PM25 ratio
2 participants