Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract interface for gridded modeldata reader #1269

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Jul 17, 2024

Change Summary

  • extract interface for gridded-model-readers (addresses parts of Split pyaerocom into seperate projects #772 )
  • apply interace to all know gridded-data readers
  • reduce public api of mscw-ctm data reader to contain only the interface

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein requested a review from dulte July 17, 2024 14:11
@heikoklein heikoklein linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (9365dc0) to head (01a158a).
Report is 6 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/io/cams2_83/reader.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1269   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
=========================================
  Files           135      136    +1     
  Lines         20766    20786   +20     
=========================================
+ Hits          16414    16431   +17     
- Misses         4352     4355    +3     
Flag Coverage Δ
unittests 79.04% <96.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein added this to the m2024-09 milestone Jul 18, 2024
@heikoklein heikoklein changed the title Implement uEMEP reader Extract interface for gridded modeldata reader Jul 19, 2024
@heikoklein heikoklein marked this pull request as ready for review July 19, 2024 09:53
@heikoklein heikoklein modified the milestones: m2024-09, m2024-08 Jul 23, 2024
pyaerocom/io/cams2_83/reader.py Show resolved Hide resolved
pyaerocom/io/cams2_83/reader.py Show resolved Hide resolved
pyaerocom/io/gridded_model_reader.py Outdated Show resolved Hide resolved
pyaerocom/io/mscw_ctm/reader.py Show resolved Hide resolved
Copy link
Collaborator

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clean up of dead code but feel free to merge after removing.

pyaerocom/io/cams2_83/reader.py Show resolved Hide resolved
@lewisblake lewisblake merged commit 8913284 into main-dev Jul 24, 2024
8 checks passed
@lewisblake lewisblake deleted the 1175-evaluation-of-uemep-output-in-pyaeroval branch July 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants